search

phetsims / expression-exchange

"Expression Exchange" is an educational simulation in HTML5, by PhET Interactive Simulations.
GNU General Public License v3.0
2 stars 2 forks source link

Expression Biopsy #34

Closed phet-steele closed 8 years ago

phet-steele commented 8 years ago

@jbphet I can't make this happen with coins, so use variables for this procedure.

On a touch screen:

  1. Make an expression
  2. Place your finger above the expression
  3. Slowly move your finger down, and use touchSnag to grab a term

https://drive.google.com/file/d/0B5V5jeifFYeSVkNuNFRQQUJsM0k/view?usp=sharing

Details:

(happened on Win 10, all browsers, and iOS 9.3.2)

phet-steele commented 8 years ago

there is NO thrown assertion when placing a term back into the expression (no duplicate). Technically, I don't think you can add it back...it seems to have never left

@jbphet I can't get the error because you removed the assertion :smile: (maybe in #11?)

jbphet commented 8 years ago

This is due to a slight protrusion of the touch and mouse areas from the bounds of the expression. Here is a screenshot from the latest dev version, http://www.colorado.edu/physics/phet/dev/html/expression-exchange/1.0.0-dev.14/expression-exchange_en.html:

ex-ex-pointer-areas

This was probably introduced during some recent changes where the baseline of the text in the coin term nodes was adjusted. I've addressed the issue by reducing the dilation of the touch areas, moving the baseline down a touch, and slightly increasing the inset in the expression.

Assigning to @phet-steele to verify that this is fixed in master.

jbphet commented 8 years ago

By the way, here's a post-fix screen shot:

ex-ex-pointer-areas-fixed

amanda-phet commented 8 years ago

Quick question: can I request that touch areas extend a bit more below the terms? On a touch device it might be nice to be able to drag a term without having to completely cover the term.

phet-steele commented 8 years ago

@jbphet I'll wait to test after you are done changing touch areas.

jbphet commented 8 years ago

I have finished adjusting pointer areas such that they don't protrude from expressions. @phet-steele - please test and indicate whether the issue appears to be resolved.

@amanda-phet - I shifted the pointer areas down as much as possible without having them protrude from the expression. Please test and see if you think this is adequate. If you'd like further work done on this, please open another issue, since anything larger will involve changes to the height of expressions.

amanda-phet commented 8 years ago

@jbphet Is it possible to publish a dev version or can you include a screenshot of the touch bounds?

jbphet commented 8 years ago

I just published a dev version, please see http://www.colorado.edu/physics/phet/dev/html/expression-exchange/1.0.0-dev.15/expression-exchange_en.html, but the bounds still poke out of the bottom just a little, so I'll need to adjust them a bit. They will look like they do in this version but just a little bit smaller in the vertical direction.

jbphet commented 8 years ago

I've adjusted the pointer areas again, and hopefully they are good to go now.

If this doesn't work, I may want to consider reducing the touch areas when a coin term is inside an expression. Right now this would be a bit tricky, because coin terms are not aware of being in an expression, but that could be changed.

amanda-phet commented 8 years ago

The pointer areas on the explore screen are a little funny for 2x and 3y. screen shot 2016-10-10 at 3 48 15 pm

Also, is there a reason for the pointer areas being different for the break-apart and edit buttons? I would make both buttons have the smaller pointer area for a mouse cursor and larger only for touch. screen shot 2016-10-10 at 3 48 47 pm 2

I can't see the areas for coins, but with my cursor I was able to roughly identify the bounds and they did not seem too big to me (within an expression- they seemed to go to the edge of the coin and include the coefficient if there was one).

jbphet commented 8 years ago

@amanda-phet

The pointer areas on the explore screen are a little funny for 2x and 3y.

On which version were you testing? I've adjusted these on master, but the changes would not yet be reflected in the current dev version (1.0.0-dev.16).

I can't see the areas for coins

The pointer areas for coins are not extended, so they just match the boundary of the nodes themselves.

[I]s there a reason for the pointer areas being different for the break-apart and edit buttons? I would make both buttons have the smaller pointer area for a mouse cursor and larger only for touch.

Good eye! I've removed the extended mouse area for the break apart button.

amanda-phet commented 8 years ago

I was testing on dev.15. Sounds like it is fixed now so that's all that matters!

Can we close this issue?

jbphet commented 8 years ago

Yes, I think we've covered it. Closing.