Closed phet-steele closed 8 years ago
there is NO thrown assertion when placing a term back into the expression (no duplicate). Technically, I don't think you can add it back...it seems to have never left
@jbphet I can't get the error because you removed the assertion :smile: (maybe in #11?)
This is due to a slight protrusion of the touch and mouse areas from the bounds of the expression. Here is a screenshot from the latest dev version, http://www.colorado.edu/physics/phet/dev/html/expression-exchange/1.0.0-dev.14/expression-exchange_en.html:
This was probably introduced during some recent changes where the baseline of the text in the coin term nodes was adjusted. I've addressed the issue by reducing the dilation of the touch areas, moving the baseline down a touch, and slightly increasing the inset in the expression.
Assigning to @phet-steele to verify that this is fixed in master.
By the way, here's a post-fix screen shot:
Quick question: can I request that touch areas extend a bit more below the terms? On a touch device it might be nice to be able to drag a term without having to completely cover the term.
@jbphet I'll wait to test after you are done changing touch areas.
I have finished adjusting pointer areas such that they don't protrude from expressions. @phet-steele - please test and indicate whether the issue appears to be resolved.
@amanda-phet - I shifted the pointer areas down as much as possible without having them protrude from the expression. Please test and see if you think this is adequate. If you'd like further work done on this, please open another issue, since anything larger will involve changes to the height of expressions.
@jbphet Is it possible to publish a dev version or can you include a screenshot of the touch bounds?
I just published a dev version, please see http://www.colorado.edu/physics/phet/dev/html/expression-exchange/1.0.0-dev.15/expression-exchange_en.html, but the bounds still poke out of the bottom just a little, so I'll need to adjust them a bit. They will look like they do in this version but just a little bit smaller in the vertical direction.
I've adjusted the pointer areas again, and hopefully they are good to go now.
If this doesn't work, I may want to consider reducing the touch areas when a coin term is inside an expression. Right now this would be a bit tricky, because coin terms are not aware of being in an expression, but that could be changed.
The pointer areas on the explore screen are a little funny for 2x and 3y.
Also, is there a reason for the pointer areas being different for the break-apart and edit buttons? I would make both buttons have the smaller pointer area for a mouse cursor and larger only for touch.
I can't see the areas for coins, but with my cursor I was able to roughly identify the bounds and they did not seem too big to me (within an expression- they seemed to go to the edge of the coin and include the coefficient if there was one).
@amanda-phet
The pointer areas on the explore screen are a little funny for 2x and 3y.
On which version were you testing? I've adjusted these on master, but the changes would not yet be reflected in the current dev version (1.0.0-dev.16).
I can't see the areas for coins
The pointer areas for coins are not extended, so they just match the boundary of the nodes themselves.
[I]s there a reason for the pointer areas being different for the break-apart and edit buttons? I would make both buttons have the smaller pointer area for a mouse cursor and larger only for touch.
Good eye! I've removed the extended mouse area for the break apart button.
I was testing on dev.15. Sounds like it is fixed now so that's all that matters!
Can we close this issue?
Yes, I think we've covered it. Closing.
@jbphet I can't make this happen with coins, so use variables for this procedure.
On a touch screen:
https://drive.google.com/file/d/0B5V5jeifFYeSVkNuNFRQQUJsM0k/view?usp=sharing
Details:
(happened on Win 10, all browsers, and iOS 9.3.2)