search

phetsims / expression-exchange

"Expression Exchange" is an educational simulation in HTML5, by PhET Interactive Simulations.
GNU General Public License v3.0
2 stars 2 forks source link

test that the challenges were all entered correctly #56

Closed jbphet closed 7 years ago

jbphet commented 7 years ago

The game screen has 8 levels with 5 challenges each for a total of 40 challenges. Each challenge has 3 equations that the user needs to construct to complete the challenge, so there are 120 equations. I've entered all of these into the code, but I did it quickly, and probably didn't get them all right. I could use some help verifying them.

I've published a version where the order of the challenges is not randomized, so they should match the order in which they are described in the spec, which should make them easier to check. The spec can be found at https://docs.google.com/document/d/1ppP9pgm0Nc0SEZbPZnrKhhXZ9JKKzurfxg7_Dvbh_rM/edit#, and the challenges are described in the tables in the "Level Overview" section. Please verify that challenges that are described in this document match those that appear in version http://www.colorado.edu/physics/phet/dev/html/expression-exchange/1.0.0-dev.19/expression-exchange_en.html of the sim. The equations and the carousel contents should be verified.

Note that the game cannot be played yet - the collection areas are not yet operational.

EDIT read this to navigate this easier @jbphet and @amanda-phet:

For @jbphet:

For @amanda-phet:

phet-steele commented 7 years ago

@amanda-phet it's my understanding that level 2 is not yet supposed to have left over terms in the carousel. Only level 8 is specified to not use all the available terms. If that's true the last challenge on level 2 has one too many "y" terms.

screen shot 2017-02-13 at 10 01 03 am

The targets add to 4 "y" terms, but there are five in the carousel. Maybe it should be "2{y}, 1{2y}"?

phet-steele commented 7 years ago

@amanda-phet Same deal in the last challenge of level 4. There are 4 "y2" terms in the targets, but 5 in the carousel.

screen shot 2017-02-13 at 10 19 51 am
phet-steele commented 7 years ago

@amanda-phet Level 5, I also could not think of a way to not have left overs in the first challenge. I always had 2{1} left over.

screen shot 2017-02-13 at 10 32 16 am
phet-steele commented 7 years ago

@jbphet, third challenge of level five, first target should be "y-2x", not "y-2y".

screen shot 2017-02-13 at 10 49 49 am

screen shot 2017-02-13 at 10 49 53 am
phet-steele commented 7 years ago

@amanda-phet first challenge of level six, I always had some combination leading to -2x being left over (whether it was 1{-2x} or 2{-x})

screen shot 2017-02-13 at 10 57 38 am
phet-steele commented 7 years ago

@jbphet 3rd challenge of level 6, carousel should contain one "-4z", not "-3z".

screen shot 2017-02-13 at 10 59 40 am

screen shot 2017-02-13 at 10 59 47 am
phet-steele commented 7 years ago

@amanda-phet the 4th challenge of level 6 is an interesting one. The left over terms equate to 0 (1{y}, 1{-y}). I can go out of my way to use them, but the simplest solution leaves them unused. This one may be okay to not change, but still noting it.

screen shot 2017-02-13 at 11 03 16 am
phet-steele commented 7 years ago

@amanda-phet the last challenge in level 6 is my first unsolvable prompt. I do not have the 12 "y" terms the targets are asking for, I only have 11.

screen shot 2017-02-13 at 11 07 56 am
phet-steele commented 7 years ago

@jbphet 3rd challenge of level 7 wants 2{3}, not 1{3}.

screen shot 2017-02-13 at 11 13 41 am

screen shot 2017-02-13 at 11 14 31 am
phet-steele commented 7 years ago

@amanda-phet the 4th challenge of level 8 is unsolvable. I cannot make a positive "2" term for the first target.

screen shot 2017-02-13 at 11 34 45 am

screen shot 2017-02-13 at 11 34 49 am
phet-steele commented 7 years ago

@jbphet I've finished and problems are noted in the string of comments above. I'll edit the first post to include a checklist of comments to make this easier to read.

jbphet commented 7 years ago

Thanks @phet-steele - that was some very thorough testing.

I've addressed the three data-entry issues that were noted, and will unassign myself until @amanda-phet has addressed the other issues. At that point, she should assign back to me and I'll implement the changes.

amanda-phet commented 7 years ago

Thanks @phet-steele . I wasn't sure how to address the issues here in github but I made changes in the design doc and highlighted them. Assigning to @jbphet to review the changes in the design doc and update the code.

jbphet commented 7 years ago

The code has now been updated based on the updates/corrections in the design document. Assigning back to @phet-steele to run through these again and see if they are all now correct.

phet-steele commented 7 years ago

Everything is correct! Thanks @jbphet and @amanda-phet.

jbphet commented 7 years ago

Thanks @phet-steele.