search

phetsims / expression-exchange

"Expression Exchange" is an educational simulation in HTML5, by PhET Interactive Simulations.
GNU General Public License v3.0
2 stars 2 forks source link

incorrect lighting for coins #83

Closed pixelzoom closed 7 years ago

pixelzoom commented 7 years ago

Noted while working on equality-explorer, which has some similarities.

The lighting on the coins is incorrect. PhET light source is above-left. The coins are lit from below-left.

screenshot_239

amanda-phet commented 7 years ago

Is light source the same as perspective, in this situation? The coins don't have highlights, but we are trying to give them depth. Should we modify the perspective to match our typical light source direction?

pixelzoom commented 7 years ago

Light source gives perspective. Rotate the visible edge of the coins 90 degrees and it'll be consistent.

amanda-phet commented 7 years ago

Done via the following commits:

https://github.com/phetsims/expression-exchange/commit/a2c2c86ca754c92e73e486771cf53d2295f9dadb

https://github.com/phetsims/expression-exchange/commit/0d4a3f525f0b916ee603b7992650646da56d460e

https://github.com/phetsims/expression-exchange/commit/b68920b26bc4053241fbd9507f4dfbbe350af226