search

phetsims / faradays-electromagnetic-lab

"Faraday's Electromagnetic Lab" is an educational simulation in HTML5, by PhET Interactive Simulations.
GNU General Public License v3.0
1 stars 0 forks source link

Incomplete sentence in Electron.ts documentation #137

Closed samreid closed 8 months ago

samreid commented 8 months ago

From #103, we observed this code https://github.com/phetsims/faradays-electromagnetic-lab/blob/c95a7b72f185d5cf982b7833cce6f7c7bbcbecf5/js/common/model/Electron.ts#L152-L156 which has an incomplete sentence in the documentation.

samreid commented 8 months ago

Note we subsequently identified a better approach in https://github.com/phetsims/faradays-electromagnetic-lab/issues/141. After implementing #141, nothing more should be needed here.

pixelzoom commented 8 months ago

I fixed the comment anyway. I'll have a look at https://github.com/phetsims/faradays-electromagnetic-lab/issues/141.