search

phetsims / faradays-electromagnetic-lab

"Faraday's Electromagnetic Lab" is an educational simulation in HTML5, by PhET Interactive Simulations.
GNU General Public License v3.0
1 stars 0 forks source link

Consistency for emf casing #147

Closed samreid closed 3 months ago

samreid commented 3 months ago

During #103 we observed this code in PickupCoil.ts:

    this._biggestAbsEmf = 0.0;

    // Check that maxEMFProperty is calibrated properly.
    if ( FELQueryParameters.calibrateEMF ) {
      this._emfProperty.lazyLink( () => this.calibrateMaxEMF() );
    }

    this.maxEMFProperty = new NumberProperty( options.maxEMF, {

We saw that some variables have Emf and some have EMF. We recommend consistency here.

pixelzoom commented 3 months ago

The only variable I found was _biggestAbsEmf. I renamed it to largestAbsoluteEMF.

I like how you used "emf" in the issue title :)