search

phetsims / faradays-electromagnetic-lab

"Faraday's Electromagnetic Lab" is an educational simulation in HTML5, by PhET Interactive Simulations.
GNU General Public License v3.0
1 stars 0 forks source link

It should be possible to hide the voltage readout on the battery #191

Closed arouinfar closed 3 months ago

arouinfar commented 3 months ago

It used to be possible to hide the the voltage readout on the battery with view.electromagnetNode.dcPowerSupplyNode.voltsText.visibleProperty.

In #178 @Nancy-Salpepi noted:

This doesn't exist: faradaysElectromagneticLab.electromagnetScreen.view.electromagnetNode.dcPowerSupplyNode.voltsText.visibleProperty

We changed the design of the electromagnets over in #163, which resulted in some refactoring. Here's the current tree structure.

image

@pixelzoom is there a way to restore this functionality?

pixelzoom commented 3 months ago

@arouinfar please review. Studio tree structure is shown below. voltsText.visibleProperty is featured.

screenshot_3403
arouinfar commented 3 months ago

Thanks @pixelzoom. The tree structure and behavior look good, but the *dCPowerSupply LinkedProperty isn't showing up in the Featured tree because dcPowerSupplyNode isn't featured. Can you please feature it?

pixelzoom commented 3 months ago

dcPowerSupplyNode is now featured. Back to @arouinfar, close if OK.

arouinfar commented 3 months ago

Looks good on main, thanks @pixelzoom. Closing.