search

phetsims / faradays-electromagnetic-lab

"Faraday's Electromagnetic Lab" is an educational simulation in HTML5, by PhET Interactive Simulations.
GNU General Public License v3.0
1 stars 0 forks source link

Increase to max 4 loops for pickup coil #41

Closed pixelzoom closed 7 months ago

pixelzoom commented 10 months ago

From https://github.com/phetsims/faradays-electromagnetic-lab/issues/33#issuecomment-1877848309:

Increase max loops to 4 for pickup coil. See PickupCoil.ts, numberOfLoopsRange: new RangeWithValue( 1, 4, 2 )

Also note from https://github.com/phetsims/faradays-electromagnetic-lab/issues/33#issuecomment-1877845336 that we will not recalibrate the model:

Increasing max loops would technically require reecalibrating the sim (see PickupCoil calibrateMaxEMF). But that would result in changes to #loops or loop radius inducing little current. The consensu was that it's OK for EMF to max out the voltmeter and light bulb sometimes.

pixelzoom commented 10 months ago

Done in the above commit. I don't see any obvious problems. But I'd like to leave this open and ready-for-review, it be reviewed either by the sim team or by QA when they do a "Quick Look" or dev test.

pixelzoom commented 7 months ago

I'm going to go ahead and close this, because we have to recalibrate everything for #156 and #66.