search

phetsims / faradays-electromagnetic-lab

"Faraday's Electromagnetic Lab" is an educational simulation in HTML5, by PhET Interactive Simulations.
GNU General Public License v3.0
1 stars 0 forks source link

UI sound for WaterFaucetNode #90

Closed pixelzoom closed 6 months ago

pixelzoom commented 6 months ago

Discussed at today's design meeting...

Version 1.0 of FEL will have UI sounds, and FaucetNode is currently the only element that does not have UI sound. Since sound design and implementation for FaucetNode is unlikely to be completed before this sim is published, I'll investigate adding some temporary UI sound in WaterFaucetNode.ts, the subclass of FaucetNode used in FEL. The consensus was that the default Slider sound would be fine.

pixelzoom commented 6 months ago

I've added temporary sounds to WaterFaucetNode, code that is specific to this sim. I used the same sounds that are used by Slider --- blips when the value changes, bloops when we reach the min and max :)

No changes were made to FaucetNode. There is a TODO in WaterFaucetNode that refers to https://github.com/phetsims/scenery-phet/issues/840 (Sound for FaucetNode). If some tries to close that issue after adding sound to FaucetNode in common code, they will be notified that they need to remove the temporary sound is WaterFaucetNode.

@arouinfar please review, close if OK.

arouinfar commented 6 months ago

Thanks @pixelzoom. I confirmed the FacetNode sounds like a slider on main. There are quite a lot of blips sounding as I interact with the FaucetNode. It seems like the sound is triggering every 1%, which makes sense since the mouse/touch interaction is continuous, but it doesn't sound very good. Is it possible to increase the interval at which the blip is triggered?

I have the same issue with the sound being generated by the other sliders in the sim, but I think the changes in #96 will likely resolve that.

pixelzoom commented 6 months ago

Yes, is it possible to increase the interval at which the sound is triggered. The interval is currently 2%. What would you prefer?

arouinfar commented 6 months ago

Let's try 5% @pixelzoom.

pixelzoom commented 6 months ago

Sound now plays when flowRateProperty (range 0-100%) changes by 5%.

@arouinfar please review, close if OK.

arouinfar commented 6 months ago

Thanks @pixelzoom. I think the FaucetNode sound is still playing too often. I know it's the same interval as the other sliders in the sim, but it doesn't feel the same because FaucetNode has a much shorter track than a typical slider. Can you please increase the interval to 10%?

pixelzoom commented 6 months ago

Changed to 10%, back to @arouinfar for review, close if OK.

arouinfar commented 6 months ago

Thanks @pixelzoom, 10% sounds good to me. Closing.