phetsims / faradays-law

"Faraday's Law" is an educational simulation in HTML5, by PhET Interactive Simulations.
http://phet.colorado.edu/en/simulation/faradays-law
GNU General Public License v3.0
1 stars 7 forks source link

Auto-slide doesn't stop if magnet grabbed while moving #203

Closed jbphet closed 3 years ago

jbphet commented 3 years ago

If the user initiates an auto-slide using keyboard navigation and then uses the mouse to grab the magnet, the animation doesn't cancel and odd behavior results.

liammulh commented 3 years ago

This looks fixed in 1.4.0-rc.1, but I'll let @KatieWoe make the final call.

KatieWoe commented 3 years ago

This does look fixed. I did notice an odd behavior where, if you start using mouse during auto slide to cancel keyboard nav, but don't actually click the magnet, auto slide will continue. If you click the magnet it will cancel. clickoutslide @jbphet if this is alright, then feel free to close. Edit: linking to rc. https://github.com/phetsims/QA/issues/581

jbphet commented 3 years ago

@KatieWoe - Yes, the behavior you describe in the comment immediately above is intentional.

Closing.