search

phetsims / faradays-law

"Faraday's Law" is an educational simulation in HTML5, by PhET Interactive Simulations.
http://phet.colorado.edu/en/simulation/faradays-law
GNU General Public License v3.0
1 stars 7 forks source link

Remove workaround code for fuzzBoard if and when possible #217

Closed jbphet closed 3 years ago

jbphet commented 3 years ago

For #216 I added some code to test for whether the method getModifierState was present on a key event. This problem only came up during fuzzBoard testing, so I think it might be a problem with that test. I've logged an issue for investigation in https://github.com/phetsims/scenery/issues/1127. When that issue is resolved, it may be possible to remove the workaround code.

Search for TODO in the code to find the code in question.

jbphet commented 3 years ago

https://github.com/phetsims/scenery/issues/1127 has been fixed, and I tried removing the workaround code and running the fuzzBoard test, and it ran fine, so the code has been committed to master. Closing.