search

phetsims / fluid-pressure-and-flow

"Fluid Pressure and Flow" is an educational simulation in HTML5, by PhET Interactive Simulations.
GNU General Public License v3.0
8 stars 5 forks source link

Icons for water tower, and flow screens #161

Open kmsravindra opened 10 years ago

kmsravindra commented 10 years ago

Could we get the icons for water tower, flow and under pressure screen

samreid commented 10 years ago

@ariel-phet, I asked @kmsravindra to create this issue and assign it to you. Not sure who you want to design/create this artwork but let us know when it's ready. So we actually need 6 icons: the icons for home screen and icons for navbar (if they differ).

ariel-phet commented 10 years ago

@samreid It looks like Bryce already made some icons that look pretty reasonable. it also seems they could be drawn in code fairly easily. Does your copy of the mockup you sent to actualconcepts have these icons depicted?

ariel-phet commented 10 years ago

I will get these icons created, but somewhat low priority since they do not need to be finished until the project is wrapping up (including Under Pressure)

ariel-phet commented 9 years ago

@amanda-phet created some nice icons, and should be emailing them to @samreid for inclusion in the sim

samreid commented 9 years ago

I have received the artwork from @amanda-phet and it looks good, but one of the files is nearly 8 MB and another is nearly 4MB. I discussed this with the other developers and we decided this is too big to put into GitHub. I wasn't sure whether to ask @amanda-phet if she can produce something that looks similar but has <1MB each or whether I should draw them in code.

amanda-phet commented 9 years ago

I can always make an image smaller (and thus lower quality).

On Oct 22, 2014, at 10:12 AM, Sam Reid notifications@github.com<mailto:notifications@github.com> wrote:

I have received the artwork from @amanda-phethttps://github.com/amanda-phet and it looks good, but one of the files is nearly 8 MB and another is nearly 4MB. I discussed this with the other developers and we decided this is too big to put into GitHub. I wasn't sure whether to ask @amanda-phethttps://github.com/amanda-phet if she can produce something that looks similar but has <1MB each or whether I should draw them in code.

— Reply to this email directly or view it on GitHubhttps://github.com/phetsims/fluid-pressure-and-flow/issues/161#issuecomment-60110769.

samreid commented 9 years ago

The issue is the size of the AI file, which should also be kept under version control. The raster image sizes are not a problem.

samreid commented 9 years ago

@ariel-phet said:

Ah...this is likely due to the fact that the faucet contains components that were drawn using the 3-d features of Illustrator.

After Mike Fowler finishes his work on the arithmetic icons, his next project is redrawing the faucet assets in 2-d which should greatly reduce this file size overhead in illustrator.

There is a fair amount of work left to be done on FPAF even once AC finishes (since there are a list of change requests) so no big rush, thanks for the update.

zepumph commented 6 years ago

@ariel-phet it may be good to get this issue going again.

zepumph commented 6 years ago

Renaming the issue since under-pressure already has a formal icon, not a mockup.

ariel-phet commented 6 years ago

@zepumph yes the 8 MB file should probably be reduced/replaced

@arouinfar might be good to start thinking about icons here. I think our "icon game" has progressed quite a bit since this sim

amanda-phet commented 6 years ago

@arouinfar I will email you the icons I created three years ago. I suspect the reason the files were large is because the artwork was created using 3D revolve (from Bryce's sim artwork), so if you can replace the water faucet with the new artwork that uses gradients, and redraw the copper-colored pipe using gradients, the file size will surely be smaller. And of course, if you're making the icons, feel free to change the design however you would like.

arouinfar commented 6 years ago

Got it, thanks @amanda-phet! I should be able to replace most things with 2D artwork. The faucet head will be more of a challenge, but I will try replacing it with a .png to see how it affects the file size/quality. Another option would be to ask Cheryl to redraw the faucet head in 2D.

arouinfar commented 6 years ago

@amanda-phet mentioned that we already have a 2D asset for the faucet, and according to https://github.com/phetsims/fluid-pressure-and-flow/issues/161#issuecomment-60438234, it looks like Mike Fowler may have been the one to create it. I haven't been able to locate the asset on Drive, and the none sims that use the faucet (Concentration, Beer's Law Lab, pH Scale, pH Scale: Basics, and Under Pressure) have the asset checked in on GitHub. Perhaps it's been drawn in code? If so, perhaps the screen icons can be something that are entirely drawn in code (from reference mockups). In the meantime, I'll work on updating the icons using the 3D faucet.

arouinfar commented 6 years ago

Tracked down the faucetNode component in scenery-phet.

arouinfar commented 6 years ago

Last update for now -- @amanda-phet found the .ai file for the 2D faucet, and it's now been added to the common components .ai file. I'll use the 2D version when mocking things up, and we can decide later whether or not the icons should ultimately be drawn in code.

arouinfar commented 6 years ago

Discussed this with @DianaTavares and she will work on updating the icons, as time allows.

DianaTavares commented 6 years ago

This are the icons fluid pressure and flow icons_pressure-icon fluid pressure and flow icons_pressure-icon-navbar fluid pressure and flow icons_flow-icon fluid pressure and flow icons_flow-icon-navbar fluid pressure and flow icons_water-tower-icon fluid pressure and flow icons_water-tower-icon-navbar

what do you think?

arouinfar commented 6 years ago

Thanks @DianaTavares! I think these icons will do for now. Looks like some of the .png dimensions were off by a px or two, so I've resized them:

pressure-screen-icon.png pressure-navbar-icon.png

flow-screen-icon.png flow-navbar-icon.png

water-tower-screen-icon.png water-tower-navbar-icon.png

The updated .ai asset (now 463 KB) for the icons can be found here: https://drive.google.com/drive/folders/0B6CMwxdP0NGYSHVaeFNsbkJkWlU

@ariel-phet can you review and reassign the appropriate dev?

ariel-phet commented 6 years ago

@arouinfar these look good, but currently this sim (unfortunately) has no planned work. I will keep it on the radar for an intern or new hire or such.

arouinfar commented 6 years ago

Understood @ariel-phet. If any issues arise from the large file size of the assets that are checked in, a dev can replace them with the assets in https://github.com/phetsims/fluid-pressure-and-flow/issues/161#issuecomment-389274545.