phetsims / fluid-pressure-and-flow

"Fluid Pressure and Flow" is an educational simulation in HTML5, by PhET Interactive Simulations.
GNU General Public License v3.0
8 stars 5 forks source link

sim relies on align:'right' default for Panels #291

Closed pixelzoom closed 8 years ago

pixelzoom commented 8 years ago

Related to https://github.com/phetsims/sun/issues/252, this sim uses minWidth and relies on the old default of align:'right' for Panels. Below are the stack traces for occurrences that need to be checked. These are the occurrences noted when loading the sim in requirejs mode. If the sim creates Panels dynamically, you should do further checking with fuzzMouse.

>>>> sim relies on align:right
VM17519 Panel.js?bust=1472221319493:56Error
    at ControlPanel.Panel [as constructor] (http://localhost/~cmalley/GitHub/sun/js/Panel.js?bust=1472221319493:52:15)
    at new ControlPanel (http://localhost/~cmalley/GitHub/fluid-pressure-and-flow/js/under-pressure/view/ControlPanel.js?bust=1472221319493:85:11)
    at new UnderPressureView (http://localhost/~cmalley/GitHub/fluid-pressure-and-flow/js/under-pressure/view/UnderPressureView.js?bust=1472221319493:82:24)
    at UnderPressureScreen.Screen.call.backgroundColor [as createView] (http://localhost/~cmalley/GitHub/fluid-pressure-and-flow/js/under-pressure/UnderPressureScreen.js?bust=1472221319493:29:34)
    at UnderPressureScreen.initializeView (http://localhost/~cmalley/GitHub/joist/js/Screen.js?bust=1472221319493:134:25)
    at UnderPressureScreen.initializeModelAndView (http://localhost/~cmalley/GitHub/joist/js/Screen.js?bust=1472221319493:151:12)
    at initializeScreen (http://localhost/~cmalley/GitHub/joist/js/Sim.js?bust=1472221319493:441:14)
    at Array.forEach (native)
    at new Sim (http://localhost/~cmalley/GitHub/joist/js/Sim.js?bust=1472221319493:439:13)
    at http://localhost/~cmalley/GitHub/fluid-pressure-and-flow/js/fluid-pressure-and-flow-main.js?
pixelzoom commented 8 years ago

Resolved in https://github.com/phetsims/under-pressure/issues/143.