search

phetsims / fluid-pressure-and-flow

"Fluid Pressure and Flow" is an educational simulation in HTML5, by PhET Interactive Simulations.
GNU General Public License v3.0
8 stars 5 forks source link

Does under-pressure need to be a phetLib? #303

Closed zepumph closed 5 years ago

zepumph commented 6 years ago

In the package.json I see:

    "phetLibs": [
      "under-pressure"
    ],

Is this necessary? I thought that the under-pressure sim uses code that lives in FPAF, not the other way around. @jonathanolson does this seem right to you?

pixelzoom commented 5 years ago

This dependency is vestigial and should be removed. user-pressure code was migrated to fluid-pressure-and-flow in #266.

pixelzoom commented 5 years ago

Dependency was remove in the above commit. Tested by doing a build, then running the built version. Closing.