search

phetsims / fluid-pressure-and-flow

"Fluid Pressure and Flow" is an educational simulation in HTML5, by PhET Interactive Simulations.
GNU General Public License v3.0
8 stars 5 forks source link

lack of assertions #330

Open pixelzoom opened 5 years ago

pixelzoom commented 5 years ago

Identified in #323 evaluation.

This sim has a surprising lack of assertions. It's 9200+ lines of code, and only contains 1 use of assert. I would expect well over 100 uses in a sim of this size and complexity.

For comparison, gas-properties is 12,500+ lines of code, and contains 486 uses of assert.