search

phetsims / fluid-pressure-and-flow

"Fluid Pressure and Flow" is an educational simulation in HTML5, by PhET Interactive Simulations.
GNU General Public License v3.0
8 stars 5 forks source link

Consider converting to default layoutBounds before PhET-iO publication #340

Closed pixelzoom closed 11 months ago

pixelzoom commented 1 year ago

This sim currently uses non-default layoutBounds. In Constants.js:

  SCREEN_VIEW_OPTIONS: { layoutBounds: new Bounds2( 0, 0, 768, 504 ) },

Per https://github.com/phetsims/phet-io/issues/1939... layoutBounds should not be changed for published PhET-iO sims because doing so may disrupt client customizations. So evaluate whether to change layoutBounds before publishing a PhET-iO version.

If you decide not to change layoutBounds, document why in Constants.js, and refer to this issue.

marlitas commented 11 months ago

Closing per dev meeting request 12/7/23.