search

phetsims / forces-and-motion-basics

"Forces and Motion: Basics" is an educational simulation in HTML5, by PhET Interactive Simulations.
http://phet.colorado.edu/en/simulation/forces-and-motion-basics
GNU General Public License v3.0
7 stars 10 forks source link

Fix layout of 'Friction' control panel #173

Closed jessegreenberg closed 8 years ago

jessegreenberg commented 8 years ago

The check boxes in the control panels are centered in their layout. This looks strange in the 'Friction' screen due to one element that has a larger width than the others.

To fix this, we should try to align the control panel items to the left to see how that looks. This way control panel layout may match across screens.

jessegreenberg commented 8 years ago

For reference...

'Acceleration' Control panel: capture

'Friction' control panel: capture2

jessegreenberg commented 8 years ago

Controls in panel are now aligned to the left. Layout after the change:

capture-1

capture-2

jessegreenberg commented 8 years ago

Hmm on very close inspection,it looks a little strange to have the slider aligned to the left with the check boxes. Maybe the slider should be centered in the panel while the check boxes are aligned to the left?

I will give this a try.

jessegreenberg commented 8 years ago

Changed the layout structure slightly so that the check boxes are aligned to the left of the panel, with the slider centered under them.

phet-steele commented 8 years ago

@jessegreenberg this fix is not in 2.0.0-dev.1, was it supposed to be? Check boxes are still centered. phetsims/tasks/issues/562

phet-steele commented 8 years ago

They don't appear to be center aligned though, so that's good (or maybe they are, what do I know!). With ?stringTest=double they look decent: doublefriction

Default is what looks wrong: singlefriction

jessegreenberg commented 8 years ago

Yes it was! I merged with another branch right before publishing dev version, maybe something was botched in the merge.

phet-steele commented 8 years ago

@jessegreenberg fixed in 2.0.0-dev.2! :tada:

jessegreenberg commented 8 years ago

Great, thanks @phet-steele.

jessegreenberg commented 8 years ago

Verified as fixed, closing.