phetsims / forces-and-motion-basics

"Forces and Motion: Basics" is an educational simulation in HTML5, by PhET Interactive Simulations.
http://phet.colorado.edu/en/simulation/forces-and-motion-basics
GNU General Public License v3.0
7 stars 10 forks source link

When should the water bucket update? #185

Closed jessegreenberg closed 8 years ago

jessegreenberg commented 8 years ago

In https://github.com/phetsims/forces-and-motion-basics/issues/181 @phet-steele pointed out that the geometry of the water bucket does not update until there is a time step, even when it is in the toolbox. The water should be level when it is home.

image

When the sim is paused, should the water geometry update when there is applied force? Or should the water level wait to update until the user hits 'Play'? Design question so assigning to @ariel-phet.

image

jessegreenberg commented 8 years ago

After thinking about it, it seems that if the acceleration readout updates when the sim is paused, the water level should as well.

jessegreenberg commented 8 years ago

The water is now always level in the toolbox and updates when the sim is paused. This seems like the correct behavior to match the acceleration readout and force vectors. @ariel-phet if this is correct, please close.

ariel-phet commented 8 years ago

@jessegreenberg I do agree the water should always be level in the toolbox.

However, I while the sim is paused, I do not think either the water bucket OR the acceleration meter should update until you have pressed play. For instance, suppose everything is stationary, you pause the sim, and then you apply a force with the slider. You have now "set up" an experiment. There is not any acceleration until you let the force actually act. When you are paused and change the applied forces or friction in paused mode you are sort of saying "here is what I want to happen" next.

jessegreenberg commented 8 years ago

I see, thank you for explaining this @ariel-phet. I will change it so that the acceleration readout and water bucket update when sim is playing (or stepped), and the water bucket will be level when home in the toolbox.

jessegreenberg commented 8 years ago

Should be fixed via #181. Water bucket doesn't update water level unless sim is playing or step is pressed. The water becomes level when the user drags the bucket. Closing.