Closed kathy-phet closed 7 years ago
@arouinfar - Can you take a look at this?
Here's what it looks like in 2.1.0
The flag can be moved up by 3px, but not much more. As for moving the sum of the forces down, I see two options. We can move it down by 20 px (top) so that the vector is not occluded (but the "Sum of Forces" text is not visible), or we can move it down by 35 px (bottom) so that both the vector and label are visible. The latter option crowds the total and component forces, so I personally prefer the first option. Any thoughts @kathy-phet?
Here's what the latter option looks like without the flag:
@arouinfar - I agree we don't want to crowd too much. What if we ...
@kathy-phet here's an updated mockup. There's 50px between the total force vector and the component vector, and I've reduced the height of the blue banner by 20%.
This seems like an improvement to me. What do you think?
I agree @kathy-phet. The latest version looks pretty good to me.
@ariel-phet can you take a look at the mockup in https://github.com/phetsims/forces-and-motion-basics/issues/213#issuecomment-260800490? I think it's an improvement over the latest version. If you think we should make this change, can you reassign and prioritize?
@arouinfar seems good to me. The banner definitely is less important than the force vectors and such, and at a smaller size it still fulfills its role.
@jessegreenberg this seems like a reasonably straightforward change, marking at medium priority, perhaps we could do a maintenance release on the latest release using the same SHA's? If it seems more involved than I am assuming, let me know.
Thanks @ariel-phet.
@jessegreenberg here's a mockup showing the changes. The Sum of the Forces has been lowered some, but Left/Right force vectors have not been moved.
Should be done in https://github.com/phetsims/forces-and-motion-basics/commit/316e4cc220d1feaa52aed6bed75d9466fb7c9807.
perhaps we could do a maintenance release on the latest release using the same SHA's
Yep, that would be best. However, I am hitting a snag in some PhET-iO code when I checkout shas and run/build off of 2.1. Ill check in with a Phet-iO developer about this and then we can redeploy.
I am hitting
Uncaught TypeError: Cannot read property 'phetioLog' of undefined(…)
@samreid and @zepumph helped isolate the isssue to a missing ifphetio statement in tandem. Sim is running off old shas again.
@arouinfar can you verify changes in this version?
If it looks good we can deploy a maintenance release off of the old shas without an RC since the minor changes were only to layout.
Looks great @jessegreenberg!
Great, thanks. Instead of deploying this right away lets also include the change to #217 since it should be quick and fit in a minor release. Closing this issue.
In playing with this simulation, I noticed that when the trial is complete the flag overlaps the Sum of Forces arrow, value, and text - such that it is difficult to see. It is still useful information though.
Can the final flag move up some, and the Sum of Forces arrow move down some, such that this overlap is eliminated?