Cart can go beyond stoppers - Githubissues

phetsims / forces-and-motion-basics

"Forces and Motion: Basics" is an educational simulation in HTML5, by PhET Interactive Simulations.

http://phet.colorado.edu/en/simulation/forces-and-motion-basics

GNU General Public License v3.0

7 stars 10 forks source link

Cart can go beyond stoppers #231

Closed jessegreenberg closed 7 years ago

jessegreenberg commented 7 years ago

Found by @phet-steele for https://github.com/phetsims/QA/issues/11. @phet-steele please feel free to include additonal information if stuff is missing.

Steps to reproduce:

Start a game of tug of war where the cart will move to one side
Just before cart wheel hits edge of stopper navigate away from current browser tab.
Return to sim tab.

The cart wheel will be beyond the stopper.

@phet-steele EDIT: good to note that switching browser tabs earlier than "just before the edge of the stopper" doesn't have the same result.

jessegreenberg commented 7 years ago

This is also a problem in the deployed version, here is a screenshot in 2.1.4:

capture

jessegreenberg commented 7 years ago

Should be fixed in the above commit.

jessegreenberg commented 7 years ago

@phet-steele, sorry, It looks like I forgot to link to this in https://github.com/phetsims/QA/issues/11. Was this verified as fixed in https://github.com/phetsims/QA/issues/11?

jessegreenberg commented 7 years ago

Ahh, nevermind @phet-steele I misunderstood the closing comment in https://github.com/phetsims/QA/issues/11, because this issue was found in https://github.com/phetsims/QA/issues/11. So 2.3 was never ready for release, but ready for a spot check. But will need a new RC anyway for #235.

jessegreenberg commented 7 years ago

Assigning to myself to verify as fixed in the next RC.

phet-steele commented 7 years ago

Fixed as far as I can tell.