phetsims / forces-and-motion-basics

"Forces and Motion: Basics" is an educational simulation in HTML5, by PhET Interactive Simulations.
http://phet.colorado.edu/en/simulation/forces-and-motion-basics
GNU General Public License v3.0
7 stars 10 forks source link

Getting error when Interaction Scale Property slider hits 0 #248

Closed ghost closed 6 years ago

ghost commented 7 years ago

Test device:

MacBook Air (13-inch, Early 2015)

Operating System:

macOS Sierra 10.12.6

Browser:

Google Chrome Version 60.0.3112.113 (Official Build) (64-bit)

Problem description:

In the Instance Proxies wrapper, I'm getting an error when I make the Interaction Scale Property slider go to 0. This is for phetsims/QA/issues/42.

Steps to reproduce:

  1. Open the Instance Proxies wrapper.
  2. Select the Motion screen.
  3. Copy and paste the following into ctrl-f: forcesAndMotionBasics.motionScreen.model.fridge.interactionScaleProperty: TProperty.
  4. Move the slider down to 0.
  5. You should notice that the refrigerator is floating in the sky, and you should be getting an error.

Screenshots:

screen shot 2017-08-29 at 4 24 11 pm

jessegreenberg commented 7 years ago

@ariel-phet @samreid should this issue be worked on at this time?

jessegreenberg commented 7 years ago

Was a quick thing to change.

jessegreenberg commented 6 years ago

Fixed merged into release branch. EDIT: just 2.3-phetio, not 2.3.

jessegreenberg commented 6 years ago

Merged into 2.3 as well.

phet-steele commented 6 years ago

Fixed.