Closed BryceAG closed 6 years ago
Fixed in the above commits, they need to be cherry-picked into 2.3 and 2.3-phetio.
Changes merged into the two release branches. Leaving open but fixed.
@jessegreenberg might as well improve panels on every screen? There's some overlap elsewhere (slider + applied force arrow):
To be clear, there are more extreme cases where overlap is going to happen anyway, but it shouldn't happen at the reasonable settings I have above.
This overlap is just going to happen...
Actually @jessegreenberg, the image I have above (the extreme one) has the "Friction Force" string going outside the dev bounds. What do you think?
I reduced max width of text in the motion screen panels to fix the case @phet-steele pointed out in https://github.com/phetsims/forces-and-motion-basics/issues/250#issuecomment-341532897.
@arouinfar and I talked about the case in https://github.com/phetsims/forces-and-motion-basics/issues/250#issuecomment-341535523. In that case we don't care that the label is going off screen because you would see the label as the arrow grows. And since it would be harder to fix than the other labels we are going to let it go.
https://github.com/phetsims/forces-and-motion-basics/commit/be4cbedb60e803fad5b4b786738fb98c61ca63f7 needs to be cherry-picked into the release branches.
Done in the above commits.
Good 'nuff.
related to phetsims/QA#57
On the Net force screen, the toggle options screen doesn't have a size limit. For string test long the mute button goes into the arrows for sum of forces:
and it is even worse for string test xss, but it doesn't have to pass for that. For string test x, the mute and reset button are uncomfortably close: