search

phetsims / forces-and-motion-basics

"Forces and Motion: Basics" is an educational simulation in HTML5, by PhET Interactive Simulations.
http://phet.colorado.edu/en/simulation/forces-and-motion-basics
GNU General Public License v3.0
7 stars 10 forks source link

use & instrument FineCoarseSpinner #274

Closed pixelzoom closed 5 years ago

pixelzoom commented 5 years ago

See https://github.com/phetsims/scenery-phet/issues/450. Please

(1) replace the UI component shown in the screenshot below with FineCoarseSpinner

(2) add PhET-iO instrumentation to FineCoarseSpinner

Assigned to @jessegreenberg per https://github.com/phetsims/scenery-phet/issues/450#issuecomment-452784491. Let me know if I can help.

screenshot_947

jessegreenberg commented 5 years ago

forces-and-motion-basics is now using FineCoarseSpinner, it was very easy to use and get the layout to match what was there before.

The FineCoarseSpinner needs to be disabled in this sim when the stack of items on the skate board is empty, so I made https://github.com/phetsims/scenery-phet/issues/461 to add that.

I am not very familiar with instrumenting for PhET-iO so I made https://github.com/phetsims/scenery-phet/issues/460 to track that specifically.

Finally, I noticed there is some overlap in the touch areas, so I opened https://github.com/phetsims/scenery-phet/issues/459 to track that.

jessegreenberg commented 5 years ago

Instrumentation was done and reviewed in https://github.com/phetsims/scenery-phet/issues/460. And FineCoarseSpinner has been reviewed and used in FAMB through the above commits and issues. This can be closed. Using this allowed us to remove ~100 lines in MotionScreenView.