search

phetsims / forces-and-motion-basics

"Forces and Motion: Basics" is an educational simulation in HTML5, by PhET Interactive Simulations.
http://phet.colorado.edu/en/simulation/forces-and-motion-basics
GNU General Public License v3.0
7 stars 10 forks source link

Use TimeControlNode for Play/Pause/Step buttons #280

Closed jessegreenberg closed 9 months ago

jessegreenberg commented 4 years ago

From phetsims/scenery-phet#561. A scenery-phet/TimeControlNode was created that combines the PlayPauseButton and StepForwardButton and includes PhET-iO and PDOM instrumentation. It should be used in this sim. Assigning to responsible dev.

jessegreenberg commented 3 years ago

The API for StepButton changed and isPlayingProperty was replaced with enabledProperty. When TimeControlNode is used in this sim the setting of enabledProperty can be removed because it is the default behavior for TimeControlNode.

amanda-phet commented 11 months ago

This seems like something that could be addressed with https://github.com/phetsims/forces-and-motion-basics/issues/304

AgustinVallejo commented 10 months ago

Addressed in the above commit. However, there is currently a slightly different behavior: When you pause the sim in the published version, the play/pause button changes scales and becomes bigger. This is not present in the TimeControlNode component and I wouldn't know how if there's currently an easy way of implementing, nor it would be consistent with other sims.

Assigning back to @amanda-phet to chime in on this and close if done

zepumph commented 10 months ago

This caused some PhET-iO validation trouble, but FAMB isn't active in its phet-io implementation, so let's turn off validation until we work on PhET-iO again.

amanda-phet commented 9 months ago

When you pause the sim in the published version, the play/pause button changes scales and becomes bigger. This is not present in the TimeControlNode component and I wouldn't know how if there's currently an easy way of implementing, nor it would be consistent with other sims.

I think the custom resizing is unnecessary and using a common component is more important. This looks good to me.