search

phetsims / forces-and-motion-basics

"Forces and Motion: Basics" is an educational simulation in HTML5, by PhET Interactive Simulations.
http://phet.colorado.edu/en/simulation/forces-and-motion-basics
GNU General Public License v3.0
7 stars 10 forks source link

Improve valueType for AnimationStateIO #282

Closed samreid closed 3 years ago

samreid commented 3 years ago

During https://github.com/phetsims/tandem/issues/211 I noted this TODO. I decided to move it to this issue. It may not need attention at the moment, but I'll assign to @zepumph since he is listed as author of the file.

const AnimationStateIO = new IOType( 'AnimationStateIO', {
  valueType: Object, // TODO:  https://github.com/phetsims/tandem/issues/211, convert to a named type
  documentation: 'Data that is stored in the "Item.animationState" Property. Type to serialize the data object across the iframe'
} );
zepumph commented 3 years ago

Unassigning until phet-io work in FAMB continues.

zepumph commented 3 years ago

Because of https://github.com/phetsims/forces-and-motion-basics/issues/285 and the creation of ObjectLiteralIO in https://github.com/phetsims/phet-io/issues/1616, @jessegreenberg and I were able to get rid of AnimationStateIO. I'm going to close this issue.