Open oliver-phet opened 4 years ago
@arouinfar although I don't think it is appropriate to have this slider be "quantized" we could consider making it a more discrete slider for experiment repetition. I feel like that would be a relatively easy change. Add some tick marks, make things more snappy (might be a good change for description in the future).
Agreed @ariel-phet. For experiment repetition, I'd go with an 11-tick slider and snap the thumb to the tick marks.
I don't think we have any sliders where the thumb snaps in the neighborhood of a tick, but is continuous elsewhere. Either it is continuous or it is snappy. We should discuss more when this sim gets design attention again, which will probably be when this sim gets an updated PhET-iO implementation.
Tagging this for design meeting to decide if we want to address with https://github.com/phetsims/forces-and-motion-basics/issues/304
To meet the goals that this user request is trying to achieve, it seems like having a way to set µ (such as in preferences) is the way to do that. When we finally do a true Forces and Motion sim we should go this route. Or with PhET-iO.
We also discussed adding tick marks (so the slider is still continuous, but has reference points) so someone a try to recreate experiments, but still allow users to finely tune how much friction they want. Adding 3 tick marks (25%, 50%, and 75%) is a simple interim way we could support the user's learning goals. The gravity force slider in MSS is similar.
Let's also investigate using hslider to add tick marks and update the thumb.
Implemented this in the above commits: Added 25%, 50%, and 75% minor tick marks, and removed the custom thumb so the default one shows, as seen below. Currently the sim is using HSlider, so we easily can leverage all the common code options, in case we need more changes to the slider, such as snapping.
Let me know if there's anything else needed here, otherwise please close if ready @amanda-phet
The applied force slider still has the old thumb. Can we update that to match as well?
Just saw this comment. The above commit addresses this. Please review and close if done.
All looks good, thanks.
Let's leave this issue open until the sim is republished with the change (I'll then reply to the user and close).