Open oliver-phet opened 3 years ago
I think we likely create a preference for the team colors and hook it up to a query parameter. Let's consider when we revisit this sim, unassigning myself for now.
Tagging for design meeting to discuss if we want to address this with https://github.com/phetsims/forces-and-motion-basics/issues/304
It would be relatively easy to recolor this artwork.
We may want to rename the code references from blue/red to left/right so it is color-agnostic (and consistent with the direction of the forces).
Considering replacing blue with purple. We will confirm that these colors pass color blindness.
I'd like to confirm here that we should add a Simulation tab to the preferences dialog, and add an option for the Net Force pullers. Not sure what to call it, or how to style it, but I'm thinking rectangular radio buttons with images of the colors, or aqua radio buttons that say "blue/red" and "purple/orange."
Orange and Purple pullers are uploaded!
For the Preferences, can you add a Simulation tab with the following for the setting:
Net Force Puller Colors
Also, can you make this a query parameter, so it is selected at sim startup for the teachers who want this feature? I'm not sure what to name it... perhaps pullerColor
and the options can be blue
or purple
?
I've added the the option to change the pullers color in the preferences tab like so:
Additionally, there is now a query parameter pullercolor
that can be set at startup. The valid values are blueRed
and purpleOrange
. I found it clearer to use these names instead of just blue
and purple
throughout the code, but I'm open to any suggestions to improve them.
I still need to change the FlagNode that's displayed when a color wins to reflect these new colors.
OK great!
Can you make sure the name of the control is in bold? I assumed it was handled by common code, but it might just be that we have to manually make it bold every time we add a preference.
Yes, that was an easy fix! I changed which font from the PreferencesDialog
it was using.
The flag node is now updated as well:
This is all now ready for your review @amanda-phet.
This looks like it's working great. Assigning to @oliver-phet to reply to the user once this sim is published.
Will this issue receive a comment when the update is published?
ON: This request is very specific (and there's likely not any combination of colors that don't have consequences in some community), but I'm posting an issue because this seems to be another example where having additional customization options would be useful to our users.