search

phetsims / forces-and-motion-basics

"Forces and Motion: Basics" is an educational simulation in HTML5, by PhET Interactive Simulations.
http://phet.colorado.edu/en/simulation/forces-and-motion-basics
GNU General Public License v3.0
7 stars 10 forks source link

Hide `left` and `right` strings from translation in 2.3 #292

Closed jessegreenberg closed 2 years ago

jessegreenberg commented 2 years ago

From @RVieyra over slack: A user reported that there are unused strings that look buggy in the translation utility for this sim. See "left" and "right" and how left is incorrectly shown twice.

Screen Shot 2022-05-24 at 11 10 35 AM (1)

These strings are currently unused and do not appear in master strings file. They were added for prototype accessibility features in 2017 and leaked into the translatable strings in that time.

Back then we marked a11y strings as hidden from the translation utility with a visible: false flag in the json strings file. This flag is used for several strings in the 2.3 branch but not these two. A maintenance release hiding these strings with this flag should be simple.

jessegreenberg commented 2 years ago

Maintenance release complete.