search

phetsims / forces-and-motion-basics

"Forces and Motion: Basics" is an educational simulation in HTML5, by PhET Interactive Simulations.
http://phet.colorado.edu/en/simulation/forces-and-motion-basics
GNU General Public License v3.0
7 stars 10 forks source link

Mystery object does not appear on Acceleration screen #302

Closed matthew-blackman closed 4 months ago

matthew-blackman commented 1 year ago

Discussing lesson use-cases of this sim with @kathy-phet, we noticed that the mystery box appears on the 'Friction' screen but not the 'Acceleration' screen. We agreed that it would be good to add it to the 'Acceleration' screen so that students can use the tools in that screen to solve for the mass of the box.

matthew-blackman commented 1 year ago

This is implemented and ready for review @kathy-phet, how would you like me to proceed?

https://github.com/phetsims/forces-and-motion-basics/assets/108756567/cb6a8981-f5ad-452b-9b42-963dc4c8405d

kathy-phet commented 1 year ago

I thought we were just making an issue - so it would be there when we visit the sim next. I didn't intend to implement it.

amanda-phet commented 8 months ago

This could likely be addressed with https://github.com/phetsims/forces-and-motion-basics/issues/304

AgustinVallejo commented 7 months ago

I reimplemented @matthew-blackman initial pair of commits for this issue. Please review if this is the intended behavior and close @marlitas

amanda-phet commented 7 months ago

Discussed 1/18/24 and would like the mystery object added, but don't need the trash can (since the water bucket is 100kg).

Luisav1 commented 6 months ago

Removed the trash can object in the above commit. image Closing.

Luisav1 commented 4 months ago

@amanda-phet caught that the trashcan was removed in the motion screen too. image Reopening to keep the trash can on the other screens except the last one.

amanda-phet commented 4 months ago

It's missing from both Motion and Friction.

Luisav1 commented 4 months ago

It seems I overlooked that the MotionModel is utilized for all three screens: Motion, Friction, and Acceleration. I've addressed this by conditionally adding back the trash can based on the screen in the commit above.

Here's how the Motion and Friction screens look now: image image Closing.