phetsims / forces-and-motion-basics

"Forces and Motion: Basics" is an educational simulation in HTML5, by PhET Interactive Simulations.
http://phet.colorado.edu/en/simulation/forces-and-motion-basics
GNU General Public License v3.0
7 stars 10 forks source link

Win flag can obscure text #324

Closed KatieWoe closed 4 hours ago

KatieWoe commented 6 days ago

Test device Samsung Operating System Win 11 Browser Chrome Problem description For https://github.com/phetsims/qa/issues/1179 If the Sum of Forces option is on in the first screen, then it will be partly obscured by the win flag when a tug of war team wins. This is rather minor, but it is different from published.

Visuals In dev test: devflag In published: pubflag

Troubleshooting information:

!!!!! DO NOT EDIT !!!!! Name: ‪Forces and Motion: Basics‬ URL: https://phet-dev.colorado.edu/html/forces-and-motion-basics/2.4.0-dev.7/phet/forces-and-motion-basics_all_phet.html Version: 2.4.0-dev.7 2024-11-26 17:47:57 UTC Features missing: applicationcache, applicationcache, touch Flags: pixelRatioScaling User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/131.0.0.0 Safari/537.36 Language: en-US Window: 1536x695 Pixel Ratio: 1.25/1 WebGL: WebGL 1.0 (OpenGL ES 2.0 Chromium) GLSL: WebGL GLSL ES 1.0 (OpenGL ES GLSL ES 1.0 Chromium) Vendor: WebKit (WebKit WebGL) Vertex: attribs: 16 varying: 30 uniform: 4096 Texture: size: 16384 imageUnits: 16 (vertex: 16, combined: 32) Max viewport: 32767x32767 OES_texture_float: true Dependencies JSON: {}
marlitas commented 1 day ago

Bounds were updating without the position being addressed. This was fixed above. Over to @KatieWoe to confirm and close if all looks well.

KatieWoe commented 1 day ago

This seems fixed. However, the text on the flag now bounces up and down as the flag waves, and it looks off.

marlitas commented 21 hours ago

Oh gosh. You're so right. How did I not notice that. Fixing.

marlitas commented 20 hours ago

Okay, this time it does not appear to be moving and things are no longer obscured... @KatieWoe can you confirm?

KatieWoe commented 4 hours ago

Looks good on main