phetsims / fourier-making-waves

"Fourier: Making Waves" is an educational simulation in HTML5, by PhET Interactive Simulations.
GNU General Public License v3.0
6 stars 3 forks source link

Wave Packet screen - control panel overlaps ResetAllButton on Chromebook #161

Closed arouinfar closed 3 years ago

arouinfar commented 3 years ago

The control panel on the Wave Packet screen overlaps with the ResetAllButton on Chromebook, so we'll need to tighten things up a bit.

@pixelzoom here are some things we can try to save space:

pixelzoom commented 3 years ago

This is undoubtedly due to differences in font size.

Reducing the size of the component spacing tool icons is a good thought. But if I make them smaller, you won't be able to see the label. @arouinfar Can I omit the label from those icons? We don't include the icon on the width indicator icon.

I'm also going to add maxHeight to the control panel, for a bit of extra protection. In the event that the control panel does exceed the available vertical space, the control panel will be uniformly scaled down to fit.

arouinfar commented 3 years ago

Yes, let's go ahead and lose the tool icon labels. We often use iconic representations for tools as checkbox labels and I think it's a reasonable thing to do here too.

pixelzoom commented 3 years ago

Hmm... I didn't think I'd miss the labels, but I do. Now I'm left wondering (or trying to remember) which tool is which. Maybe that's OK. Or we could put the labels to the left of the icons?

@arouinfar thoughts?

With labels:

screenshot_1214

Without labels:

screenshot_1213
pixelzoom commented 3 years ago

Labels to the left of icons looks best to me, to I went with that. It doesn't both me that the label is in a different location than it is on the interactive tool. And as a bonus, we can make the labels a bit larger. Screenshot below.

I also set maxWidth and maxHeight for the control panel, as a fallback. In case we miss something, this will guarantee that the control panel doesn't overlap anything. Tested with ?stringTest.

@arouinfar please review in master.

screenshot_1216
arouinfar commented 3 years ago

Thanks @pixelzoom! I really like the labels on the left. The unlabelled tools didn't look as good as I thought they would.