search

phetsims / fourier-making-waves

"Fourier: Making Waves" is an educational simulation in HTML5, by PhET Interactive Simulations.
GNU General Public License v3.0
6 stars 3 forks source link

Use EnabledProperty. #164

Closed pixelzoom closed 3 years ago

pixelzoom commented 3 years ago

Related to #163...

  • [ ] When defining a boolean Property to indicate whether something is enabled, use AXON/EnabledProperty. This should be done in both the model and the view.

This is a new requirement that I was not aware of. Even though the 1.0 release will not include PhET-iO, I'm going to address this now.

pixelzoom commented 3 years ago

All of the enabledProperty instances in Fourier are DerivedProperty, so it's impossible (and inappropriate) to use EnabledProperty. So I'm going to ignore this CRC item, and revise it in the template.