Code polishes - Githubissues

phetsims / fourier-making-waves

"Fourier: Making Waves" is an educational simulation in HTML5, by PhET Interactive Simulations.

GNU General Public License v3.0

6 stars 3 forks source link

Closed pixelzoom closed 2 years ago

pixelzoom commented 2 years ago

For #165 code review, @jonathanolson and I discussed a couple of other potential polishes:

[x] More liberal use of type expressions for local vars (reduce code searches)
[x] Type expressions for this.fields defined at end of constructor (reduce code searches)
[x] Review calls to Property setDeferred
[x] Replace _.filter with built-in
[x] Replace _.map with built-in
[x] Replace for loops with map or forEach

pixelzoom commented 2 years ago

Done, closing.