search

phetsims / fourier-making-waves

"Fourier: Making Waves" is an educational simulation in HTML5, by PhET Interactive Simulations.
GNU General Public License v3.0
6 stars 3 forks source link

Width Indicator label is cut off #198

Closed Nancy-Salpepi closed 2 years ago

Nancy-Salpepi commented 2 years ago

Test device MacBook Air (m1 chip)

Operating System 11.6

Browser Safari

Problem description In the Wave Packet Screen, when using query parameter ?stringTest=long the Width Indicator Label appears cut off in the top panel.

Visuals Amplitudes of Fourier Components Panel:

Screen Shot 2021-09-29 at 1 32 31 PM

Compare to Sum Panel:

Screen Shot 2021-09-29 at 1 36 19 PM
Troubleshooting information: !!!!! DO NOT EDIT !!!!! Name: 12345678901234567890123456789012345678901234567890 URL: https://phet-dev.colorado.edu/html/fourier-making-waves/1.0.0-rc.1/phet/fourier-making-waves_all_phet.html?stringTest=long Version: 1.0.0-rc.1 2021-09-28 15:44:23 UTC Features missing: touch Flags: pixelRatioScaling User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/605.1.15 (KHTML, like Gecko) Version/15.0 Safari/605.1.15 Language: en-US Window: 1440x675 Pixel Ratio: 2/1 WebGL: WebGL 1.0 GLSL: WebGL GLSL ES 1.0 (1.0) Vendor: WebKit (WebKit WebGL) Vertex: attribs: 16 varying: 31 uniform: 1024 Texture: size: 16384 imageUnits: 16 (vertex: 16, combined: 32) Max viewport: 16384x16384 OES_texture_float: true Dependencies JSON: {}
pixelzoom commented 2 years ago

Thanks @Nancy-Salpepi. I neglected to set maxWidth for the width indicators. Fixed in the above commits in master and 1.0. See screenshot below. Ready for verification in the next RC.

screenshot_1300
pixelzoom commented 2 years ago

To verify in the next RC:

  1. Run the sim with ?stringTest=long
  2. Go to Wave Packet screen
  3. Verify that the width indicators look OK, like in the screenshot above.
Nancy-Salpepi commented 2 years ago

Width indicators look OK now.