Add "Thanks" to credits.

phetsims / fourier-making-waves

"Fourier: Making Waves" is an educational simulation in HTML5, by PhET Interactive Simulations.

GNU General Public License v3.0

6 stars 3 forks source link

Add "Thanks" to credits. #208

Closed kathy-phet closed 2 years ago

kathy-phet commented 2 years ago

So sorry I didn't think of this earlier, but today I was going to send the sim to STROBE leadership - as the funder, and checked and realized we hadn't added them to the "Thank you".

This is what is in Wave Interference: Thanks To This material is based upon work supported by the National Science Foundation under STROBE Grant No. DMR 1548924.

I will check to make sure this is the right credit.

@pixelzoom - is this something that can be a maintenance release for this sim only? Again - apologies for the oversight.

pixelzoom commented 2 years ago

Yes, this can be a maintenance release for this sim only. Assigning back to @kathy-phet to verify the credits. I'll also need to know whether you want this to go through an RC spot-check.

arouinfar commented 2 years ago

@kathy-phet @pixelzoom this is the "Thanks To" credit we used for wave-interference. Can we use the same in Fourier?

    thanks: 'This material is based upon work supported by the National Science Foundation under STROBE Grant No. DMR ' +
            '1548924. Any opinions, findings, and conclusions or recommendations expressed in this material are those ' +
            'of the author(s) and do not necessarily reflect the views of the National Science Foundation.'

Also, I just noticed Wieman is misspelled, so we should fix that too.

kathy-phet commented 2 years ago

I've emailed them ... waiting for reply. They have been renewed, so I don't know if I need another award number or if its the same one.

kathy-phet commented 2 years ago

@arouinfar - I noticed that the in-sim credit and the sim-page credit for Wave Interference are different. Do you recall why?

pixelzoom commented 2 years ago

@arouinfar said:

Also, I just noticed Wieman is misspelled, so we should fix that too.

Different issue, tracking in https://github.com/phetsims/fourier-making-waves/issues/210.

pixelzoom commented 2 years ago

@kathy-phet said:

@arouinfar - I noticed that the in-sim credit and the sim-page credit for Wave Interference are different. Do you recall why?

Different issue, tracking in https://github.com/phetsims/wave-interference/issues/525

kathy-phet commented 2 years ago

STROBE got back to me. Here is what they would like in Fourier:

We gratefully acknowledge support from STROBE NSF Science & Technology Center Grant DMR-1548924. Any opinions, findings, and conclusions or recommendations expressed in this material are those of the author(s) and do not necessarily reflect the views of the National Science Foundation.

pixelzoom commented 2 years ago

I've added the "Thanks" section to master and 1.0 branches. Here's what it looks like:

pixelzoom commented 2 years ago

I'll also need to know whether you want this to go through an RC spot-check.

We're going to skip QA and publish 1.0.1 directly.

Slack conversation

Chris Malley 3:52 PM For the updates to Fourier credits, do you want the sim to go through an RC spot-check? Or are you comfortable skipping QA and publishing 1.0.1 ? I would be comfortable skipping QA, because only the credits file has been changed. Kathy Perkins 3:53 PM I trust your judgement here. So if you are comfortable, sounds good to me. Chris Malley 3:54 PM Thanks. I’ll proceed with 1.0.1. I’m also comfortable with this because we frequently revise the QA credits after the last RC, just before publication.

pixelzoom commented 2 years ago

Published in 1.0.1. Closing.