phetsims / fourier-making-waves

"Fourier: Making Waves" is an educational simulation in HTML5, by PhET Interactive Simulations.
GNU General Public License v3.0
6 stars 3 forks source link

"Third-Party Libraries" credits do not appear on the PhET website. #209

Closed kathy-phet closed 2 years ago

kathy-phet commented 2 years ago

While looking at "Thanks to" credits, I noticed that this sim is missing the Sherpa credits on the sim page --

Numberline distance looks like this: image

But Fourier has a blank for Third-Party Libraries which seems highly unlikely.

Is this a bug in the build process?

pixelzoom commented 2 years ago

Sorry, this outside of my wheelhouse. If I had to speculate... like alterntive images, this might be one of those "wait for it" things.

arouinfar commented 2 years ago

@kathy-phet third-party libraries usually take a while to show up due to caching.

samreid commented 2 years ago

I ran grunt report-third-party and it populuated the admin 3rd-party-libraries text box. I also pushed the changes to the sherpa md file in https://github.com/phetsims/sherpa/commit/a17cf3512f02e85fc024a3d80b421a3139c6f3ee.

Ah, it looks like it is supposed to run during the “daily grunt work” which runs at 3:24am mountain time every day.

pixelzoom commented 2 years ago

Just to validate my speculation :)... In Slack, @arouinfar said:

3rd party credits is automatically populated. I never add it, but I think it might take time to show up due to caching

kathy-phet commented 2 years ago

Sorry for the red herring. Closing this.

pixelzoom commented 2 years ago

Reopening. It's been > 24 hours, and 3rd-party credits have not appeared for Fourier.

screenshot_1348
pixelzoom commented 2 years ago

In https://github.com/phetsims/fourier-making-waves/issues/211#issuecomment-943547485, @mattpen said that this is due to server-side caching, and "I’ll clear the metadata cache, which should make it visible within an hour".

mattpen commented 2 years ago

It should be showing up now (you'll need to open it in a new tab or delete your session storage for phet.colorado.edu in an existing tab)

pixelzoom commented 2 years ago

Great, I now see the alternative screenshots at https://phet.colorado.edu/en/simulations/fourier-making-waves. Thanks @mattpen!