phetsims / fourier-making-waves

"Fourier: Making Waves" is an educational simulation in HTML5, by PhET Interactive Simulations.
GNU General Public License v3.0
6 stars 3 forks source link

small parts of the translated text is lagging behind sim's components #213

Closed DianaTavares closed 3 years ago

DianaTavares commented 3 years ago

We translate the Fourier simulation into spanish and the translation of "component Spacing" that is "Espacio de Componentes" in the "Wave Packet" screen is getting behind the i control:

image

I share this with @arouinfar, and she can reproduce it with text, but not with stringTest=long: image

arouinfar commented 3 years ago

I share this with @arouinfar, and she can reproduce it with text

@pixelzoom this issue appears when editing wavePacketScreen.view.controlPanel.componentSpacingSubpanel.componentSpacingText.textProperty in Studio.

Using stringTest=double on the published Spanish version shows an appropriate maxWidth image

pixelzoom commented 3 years ago

I can easily reproduce this problem.

Interesting that this problem does not occur for the Discrete control panel, where we also have an Info button to the right of a label ("Fourier Series"). I'll investigate.

pixelzoom commented 3 years ago

I do not see a published Spanish translation on the PhET website. But I can see this same problem with the Portuguese (Brazil) translation on the PhET website:

screenshot_1377

I fixed this in master and 1.0 branches, published 1.0.2-rc.1, and confirmed that the Portuguese translation is fixed by running https://phet-dev.colorado.edu/html/fourier-making-waves/1.0.2-rc.1/phet/fourier-making-waves_all_phet.html?locale=pt_BR:

screenshot_1378

Finally, I published production version 1.0.2.

@DianaTavares please verify that this has fixed the problem with your Spanish translation. If everything is OK, please close this issue.

DianaTavares commented 3 years ago

Working! image