search

phetsims / fourier-making-waves

"Fourier: Making Waves" is an educational simulation in HTML5, by PhET Interactive Simulations.
GNU General Public License v3.0
6 stars 3 forks source link

Remove unnecessary rich enumeration in Waveform.js. #214

Closed pixelzoom closed 2 years ago

pixelzoom commented 2 years ago

While working on https://github.com/phetsims/chipper/issues/1106 with @samreid, I noticed that fourier-making-waves is using a rich enumeration pattern where it's not necessary. In Waveform.js, it's sufficient to have a set of static instances -- the same pattern used in ph-scale.Solute.

pixelzoom commented 2 years ago

Done in the above commit. Closing.