Levels that are not included in `?gameLevels` should not be shown in game Info dialog.

phetsims / fourier-making-waves

"Fourier: Making Waves" is an educational simulation in HTML5, by PhET Interactive Simulations.

GNU General Public License v3.0

6 stars 3 forks source link

Levels that are not included in `?gameLevels` should not be shown in game Info dialog. #222

Open pixelzoom opened 2 years ago

pixelzoom commented 2 years ago

On hold until general design decisions have been made, see https://github.com/phetsims/vegas/issues/104#issuecomment-1102871139.

pixelzoom commented 2 years ago

In https://github.com/phetsims/vegas/issues/104#issuecomment-1108956635, @arouinfar gave the go-ahead for this.

pixelzoom commented 2 years ago

@arouinfar please review in master. For example, test with ?gameLevels=1,3,5 and verify that the correct level-selection buttons and level descriptions (in the Info dialog) are shown.

arouinfar commented 2 years ago

Looks good in master @pixelzoom. Since this is an unpublished change, I've tagged with status:fixed-awaiting-deploy.

pixelzoom commented 16 hours ago

Ready for testing in https://github.com/phetsims/qa/issues/1178. You may close this issue if it looks OK.

To test:

Run with ?gameLevels to select specific levels in the game. For example ?gameLevels=1,3.
Go to the Wave Game screen.
Press the Info button to open the "Levels" dialog.
Verify that only the levels that were present in gameLevels are present in the "Levels" dialog.