phetsims / fourier-making-waves

"Fourier: Making Waves" is an educational simulation in HTML5, by PhET Interactive Simulations.
GNU General Public License v3.0
6 stars 3 forks source link

CT: value failed isValidValue: Infinity #226

Closed KatieWoe closed 1 year ago

KatieWoe commented 1 year ago
fourier-making-waves : phet-io-fuzz : unbuilt
https://bayes.colorado.edu/continuous-testing/ct-snapshots/1667827556469/fourier-making-waves/fourier-making-waves_en.html?continuousTest=%7B%22test%22%3A%5B%22fourier-making-waves%22%2C%22phet-io-fuzz%22%2C%22unbuilt%22%5D%2C%22snapshotName%22%3A%22snapshot-1667827556469%22%2C%22timestamp%22%3A1667831155540%7D&ea&brand=phet-io&phetioStandalone&fuzz&memoryLimit=1000
Query: ea&brand=phet-io&phetioStandalone&fuzz&memoryLimit=1000
Uncaught Error: Assertion failed: validation failed:
value failed isValidValue: Infinity
prunedValidator:
[object Object]
Error: Assertion failed: validation failed:
at window.assertions.assertFunction (https://bayes.colorado.edu/continuous-testing/ct-snapshots/1667827556469/assert/js/assert.js:28:13)
at assert (validate.ts:25:16)
at validate (StateSchema.ts:203:8)
at checkStateObjectValid (IOType.ts:421:42)
at isStateObjectValid (IOType.ts:461:9)
at validateStateObject (IOType.ts:298:23)
at toStateObject (ReadOnlyProperty.ts:302:34)
at getData (PhetioObject.ts:484:45)
at phetioStartEvent (ReadOnlyProperty.ts:297:66)
at _notifyListeners (ReadOnlyProperty.ts:262:13)
id: Bayes Puppeteer
Snapshot from 11/7/2022, 6:25:56 AM

----------------------------------

fourier-making-waves : phet-io-fuzz : unbuilt
https://bayes.colorado.edu/continuous-testing/ct-snapshots/1667827556469/fourier-making-waves/fourier-making-waves_en.html?continuousTest=%7B%22test%22%3A%5B%22fourier-making-waves%22%2C%22phet-io-fuzz%22%2C%22unbuilt%22%5D%2C%22snapshotName%22%3A%22snapshot-1667827556469%22%2C%22timestamp%22%3A1667835911181%7D&ea&brand=phet-io&phetioStandalone&fuzz&memoryLimit=1000
Query: ea&brand=phet-io&phetioStandalone&fuzz&memoryLimit=1000
Uncaught Error: Assertion failed: validation failed:
value failed isValidValue: Infinity
prunedValidator:
[object Object]
Error: Assertion failed: validation failed:
at window.assertions.assertFunction (https://bayes.colorado.edu/continuous-testing/ct-snapshots/1667827556469/assert/js/assert.js:28:13)
at assert (validate.ts:25:16)
at validate (StateSchema.ts:203:8)
at checkStateObjectValid (IOType.ts:421:42)
at isStateObjectValid (IOType.ts:461:9)
at validateStateObject (IOType.ts:298:23)
at toStateObject (ReadOnlyProperty.ts:302:34)
at getData (PhetioObject.ts:484:45)
at phetioStartEvent (ReadOnlyProperty.ts:297:66)
at _notifyListeners (ReadOnlyProperty.ts:262:13)
id: Bayes Puppeteer
Snapshot from 11/7/2022, 6:25:56 AM
pixelzoom commented 1 year ago

Reproduced in phetmarks with this URL: http://localhost:8080/fourier-making-waves/fourier-making-waves_en.html?ea&brand=phet-io&phetioStandalone&fuzz

I could not reproduce with brand=phet, so it appears to be specific to PhET-iO.

I cannot identify what is causing this failure from the stack trace.

This failure started recently (in the last week?), and the commit history shows no sim-specific PhET-iO changes. So I suspect something changed in common code.

@zepumph @samreid any ideas?

samreid commented 1 year ago

@marlitas and I fixed it in the commit, by using InfiniteNumberIO which @zepumph introduced in https://github.com/phetsims/tandem/issues/280. Closing.

zepumph commented 1 year ago

Ha! I was just typing this up. Amazing. Thanks for the find. Looks like I forgot to bring that other issue to you to review.