search

phetsims / fourier-making-waves

"Fourier: Making Waves" is an educational simulation in HTML5, by PhET Interactive Simulations.
GNU General Public License v3.0
6 stars 3 forks source link

Test pdomOrder for Wave Game screen #232

Closed pixelzoom closed 1 year ago

pixelzoom commented 1 year ago

When WaveGameLevelNode was converted to TypeScript, it exposed this error which was fixed in https://github.com/phetsims/fourier-making-waves/commit/19ab0c12:

- this.pDomOrder = [
+ this.pdomOrder = [

This change needs to be tested, to confirm that the order is still correct. Compare to the published version.

pixelzoom commented 1 year ago

I confirmed that the traversal order in master matches published version 1.0.13. We got lucky - the scengraph order matches the pdomOrder.

Closing.