phetsims / fractions-common

Common code for Fractions simulations
MIT License
0 stars 1 forks source link

Bring container/fraction to the front when pieces are dropped in? #44

Closed phet-steele closed 5 years ago

phet-steele commented 5 years ago

Imagine you have two shapes overlapping like this on a lab screen:

image

I think it would be best that dropping a circle piece into the back one would bring the entire shape to the front. Currently it stays behind:

image

Just a thought. For phetsims/QA/issues/250.

KatieWoe commented 5 years ago

This also occurs in the game. When focus is on a group of shapes they are in the front, but you can drop pieces in even when they aren't in focus.

amanda-phet commented 5 years ago

If it's not to difficult for @jonathanolson to change, I think this would be fine. But the pieces can easily be rearranged at any time, so I am ok if this needs to be deferred.

jonathanolson commented 5 years ago

Implemented above, can you verify?

KatieWoe commented 5 years ago

This looks good. I did notice that, when dragging the piece, sometimes any active buttons (the plus and minus, the left and right arrow, and the back arrow) will stay up and sometimes they disappear while dragging. I can't seem to determine when this occurs and when it doesn't though.

jonathanolson commented 5 years ago

Hmm, I'm not seeing what I think you mean. Would you be able to record this behavior?

KatieWoe commented 5 years ago

@jonathanolson I think it stays if you've hit the plus/minus sign last, or the arrows, and may disappear otherwise.

disappearingbuttons

phet-steele commented 5 years ago

I think it stays if you've hit the plus/minus sign last, or the arrows, and may disappear otherwise.

That's what I see. Otherwise, bringing objects to the front is working well.

jonathanolson commented 5 years ago

This should be fixed with the above commit. Can you confirm?

KatieWoe commented 5 years ago

Behavior now seems more consistent on master. When a piece is dragged from the tool bar the buttons disappear under both circumstances described above. @jonathanolson

jonathanolson commented 5 years ago

Thanks! I believe that should be everything for this issue, closing.