search

phetsims / fractions-common

Common code for Fractions simulations
MIT License
0 stars 1 forks source link

Level select titles are missing and verbose (sometimes) #53

Closed phet-steele closed 5 years ago

phet-steele commented 5 years ago

The level select screens in FI, FMN, and BAF do not have a title, unlike FE and FM:

image

Furthermore, the only reason the title “Fractions: Choose your level!” is used in the FM level select is because “Fractions” is the name of the screen. The other screen in that sim is named “Mixed Numbers” and therefore the title says “Mixed Numbers: Choose your level!”. All that being said, the game screen in FE (above screenshot) still says “Fractions: Choose your level!” while the word “Fractions” in the title doesn’t make sense to belong there. The name of the screen in FE is simply “Game” and only has that one type of game.

So I'd propose stripping "Fractions: " from the title of the level select in FE, then adding "Choose your level!" as a title in FI, FMN, and BAF. All of this in the name of consistency. @ariel-phet?

For phetsims/QA/issues/250.

amanda-phet commented 5 years ago

So I'd propose stripping "Fractions: " from the title of the level select in FE, the adding "Choose your level!" as a title in FI, FMN, and BAF. All of this in the name of consistency.

That's my vote as well. FM still needs those titles, but if we can make that change in FE I think that would be best.

jonathanolson commented 5 years ago

So to be clear, this would leave fraction-matcher in the same state as it is now, but when the matcher screen is in fractions-equality it would only have "Choose your level!" (instead of the current behavior)?

Also if we're adding this to the newer game screens, I assume you don't want the text sliding left/right when the level icons do?

ariel-phet commented 5 years ago

@jonathanolson yes you are correct when you say:

leave fraction-matcher in the same state as it is now, but when the matcher screen is in fractions-equality it would only have "Choose your level!"

In addition, I agree, we do not need the text sliding left/right when the level icons slide.

amanda-phet commented 5 years ago

So to be clear, this would leave fraction-matcher in the same state as it is now, but when the matcher screen is in fractions-equality it would only have "Choose your level!" (instead of the current behavior)?

Yes, that is correct.

jonathanolson commented 5 years ago

Should be implemented, does this look good?

phet-steele commented 5 years ago

This looks fine to me @jonathanolson. But now that I see it, maybe fraction-matcher could just say "Choose Your Level!" without the prefix as well.

phet-steele commented 5 years ago

@amanda-phet different sims have different fonts for this title, just FYI in case you care.

ariel-phet commented 5 years ago

@jonathanolson @phet-steele I don't think we want to touch Fraction Matcher for the moment.

@phet-steele feel free to make a separate "polish" issue regarding fonts. Might wait until after 1.0, but good to note.

Closing