search

phetsims / fractions-common

Common code for Fractions simulations
MIT License
0 stars 1 forks source link

No reward for beating 10 levels iOS #65

Closed KatieWoe closed 5 years ago

KatieWoe commented 5 years ago

Device iPad (2018) OS iOS 12 Browser Safari For https://github.com/phetsims/QA/issues/253. Need to check other sims. Upon beating Level 10 (and all others before) in Fractions Mixed Numbers (building shapes to match fractions) the sound played and the dialog popped up, but no confetti dropped. Was in portrait mode at the time. Edit: Same for other type of game in Fractions Mixed Numbers Edit 2: Occurs in Landscape as well

KatieWoe commented 5 years ago

Also in https://github.com/phetsims/QA/issues/252 and https://github.com/phetsims/QA/issues/250 Does not occur when a level is beaten in Fractions: Equality

ariel-phet commented 5 years ago

@jonathanolson - this would certainly be good to fix, but I do not see it as essential for publishing 1.0

Marking priority:4-low

jonathanolson commented 5 years ago

I was under the impression that this was a desired feature, since the performance of the RewardNode was low. There is code explicitly preventing the RewardNode from showing up on mobile safari.

Should I remove that condition? (It's easy to do)

KatieWoe commented 5 years ago

I wasn't aware that this was intended. It doesn't bother me, so if this improves performance I don't see a problem.

ariel-phet commented 5 years ago

@KatieWoe @jonathanolson forgot this was intentional. Closing.