search

phetsims / fractions-common

Common code for Fractions simulations
MIT License
0 stars 1 forks source link

View Time Records in game for Fractions: Equality #66

Closed KatieWoe closed 5 years ago

KatieWoe commented 5 years ago

I noticed that there doesn't seem to be any record of the time you got on different levels you've already beaten when playing the game in fractions: equality. This seems a bit odd to me since I think this was possible in other games. Not necessary, but I thought it might be a good feature to bring up. For https://github.com/phetsims/QA/issues/251

ariel-phet commented 5 years ago

I believe we had time recorded in a early version of fraction matcher, I will see if I can trace down the published version that had it.

ariel-phet commented 5 years ago

@KatieWoe do you mean a time recorded on the level selection screen?

@jonathanolson I believe there is a "best time" option in Vegas that will display best times on the level selection icons. But perhaps that is best to included when we revisit the Fraction Matcher code? Let me know.

KatieWoe commented 5 years ago

@ariel-phet yes that is what I mean.

jonathanolson commented 5 years ago

But perhaps that is best to included when we revisit the Fraction Matcher code? Let me know.

Probably best, yes.

ariel-phet commented 5 years ago

OK, marking deferred

jonathanolson commented 5 years ago

I believe this was implemented:

Screen Shot 2019-06-07 at 11 41 51 AM

@KatieWoe is there anything else to do for this issue?

KatieWoe commented 5 years ago

I don't believe anything else had to be done. I'll look for any bugs when it comes up for rc. Edit: unless you mean to check now. Sorry, issue was a bit unclear

KatieWoe commented 5 years ago

Things look ok. I noticed that the time record disappears if you make a mistake, and will come back if you complete again perfectly with the correct record whether or not you set it that time or its the old record. I think that is fine.

jonathanolson commented 5 years ago

I noticed that the time record disappears if you make a mistake, and will come back if you complete again perfectly with the correct record whether or not you set it that time or its the old record. I think that is fine.

I believe that was the desired behavior, so I'm going to close the issue. Thanks!