search

phetsims / fractions-common

Common code for Fractions simulations
MIT License
0 stars 1 forks source link

Equality Lab Firefox Issues #81

Closed JRomero0613 closed 5 years ago

JRomero0613 commented 5 years ago

Test Device: Magnus OS: 10.11.6 Browser: Firefox 64.0.2 Problem Description: For https://github.com/phetsims/QA/issues/260 when on the equality lab screen of Fractions: Equality the denominator can be changed to seven and zero. When holding down the arrow key to increase the denominator, the denominator will increase past six to seven, likewise for decreasing past one to zero. The sim will continue to function properly and there are no issues with moving "1/7" pieces around, however if the denominator goes to zero the sim will break, and nothing can be manipulated. The major issue concerns having the denominator go to zero where the sim breaks. It should be noted that both the up and down arrow are greyed out at the respective values of six and one, showing that the denominator should not be able to be manipulated further in whichever direction is greyed out. I haven't been able to find exact conditions to reproduce so simply decrease and increase the denominator by holding the button for a couple of seconds until the issue has occurred. It seems to happen most often when the sim has just been launched or reloaded. I have attached a screenshot of the sim when the denominator is seven and zero for reference. In the console there are no errors thrown when the denominator is seven, but an unexpected value matrix of (NaN) alert is given when the denominator is zero. screen shot 2019-01-24 at 12 07 35 pm

screen shot 2019-01-24 at 11 55 28 am

KatieWoe commented 5 years ago

Have managed to reproduce 10.14.3 firefox. Only just after refreshing and after while it got harder, possibly due to caching. Did not have the grayed out buttons, but I may have misunderstood the steps.

KatieWoe commented 5 years ago

Haven't reproduced using similar tools in the other sims, but I wouldn't necessarily rule it out.

ariel-phet commented 5 years ago

@jonathanolson this seemed difficult to reproduce and rare (I watched @KatieWoe)

This bug is definitely not a showstopper for 1.0. If it is an easy fix (in the 10 or 15 minute range) feel free to fix. If not, please mark deferred and we will fix after 1.0 is published.

KatieWoe commented 5 years ago

Replicated at least once on Win 10 firefox.

jonathanolson commented 5 years ago

Added a patch that should hopefully prevent this (and pushed it to the RC branches).

@KatieWoe can you see if this makes it impossible for the given bug to occur?

KatieWoe commented 5 years ago

1.0.0-rc.2 unable to reproduce on this version. Will still keep an eye out for it and would like @JRomero0613 to take a look if he has the chance, since I was unable to reproduce some of the effects he saw.

amanda-phet commented 5 years ago

@KatieWoe since QA testing is done, can this issue be closed?