search

phetsims / fractions-intro

"Fractions Intro" is an educational simulation in HTML5, by PhET Interactive Simulations.
MIT License
1 stars 3 forks source link

add dispose functions to VerticalBarNode, BeakerNode, NumberLineNode, and CakeNode #64

Closed veillette closed 7 years ago

veillette commented 7 years ago

All the representation nodes do not have a dispose function, leading to memory leaks.

jonathanolson commented 7 years ago

Handling this soon would help, as fuzzing causes it to leak many GBs of memory (which is likely to be the culprit for our continuous testing having Chrome crashes lately).

coledu commented 7 years ago

We pushed a commit that should add the dispose function for all the existing representations. It is being implemented in IntroScreenView.

veillette commented 7 years ago

BucketNode is constantly adding and removing scenery nodes in the bucket (as well as icon on the bucket). This is a very likely source of memory leak.

coledu commented 7 years ago

We will need to go though the proto branch and make sure we dispose of everything that need to be dispose of. Since we switch over to the proto branch is this still an issue with the bucket? What you mention in you last comment. @veillette .

veillette commented 7 years ago

This is no longer a relevant issue. Closing