search

phetsims / fractions-intro

"Fractions Intro" is an educational simulation in HTML5, by PhET Interactive Simulations.
MIT License
1 stars 3 forks source link

Implement a mass animation of Container nodes as max spinner is decreased #75

Closed michaelm396 closed 5 years ago

michaelm396 commented 7 years ago

Currently in Fractions-proto, it does not enable the sim to mass animate nodes from the screen view to the bucket view as the maxProperty is decreased. In Fractions-Intro this is done in the introModel. (intro/introModel)

if ( this.representationProperty.value !== Representation.NUMBER_LINE ) {

  // move those cells to the bucket
  if ( cellsToAnimate > 0 ) {
    for ( var i = 0; i < cellsToAnimate; i++ ) {
      self.addAnimatingPieceAtCell();
    }
  }
}

We want to emulate this feature.

michaelm396 commented 7 years ago

Hey @jonathanolson Johnathan, We have been adamantly working to make changes to the prototype fractions intro file. These changes are included in a prioritized checklist to get us started with transitioning the proto branch of Fractions-intro into the master branch (see issue #68 for list). I am going to be assigning you these mapped issues for any further review. Thanks.