search

phetsims / fractions-intro

"Fractions Intro" is an educational simulation in HTML5, by PhET Interactive Simulations.
MIT License
1 stars 3 forks source link

BeakerNode should be used to generate an Icon for the Panel Representation #77

Closed veillette closed 5 years ago

veillette commented 7 years ago

The view of the Beaker Node has hard coded value for the beaker size. You should relax these conditions so that they are passed as options instead. with the hard coded values as default values.

coledu commented 7 years ago

Assigning back to @veillette . I made the option to change the size of the beaker. We discuss adding in a perspective or scaling options to avoid use x Radius and Y radius as a options. Also should I have assign you or Jonathon?

veillette commented 7 years ago

Good job @coledu. Assigning to @jonathanolson for review.