phetsims / friction

"Friction" is an educational simulation in HTML5, by PhET Interactive Simulations.
http://phet.colorado.edu/en/simulation/friction
GNU General Public License v3.0
4 stars 6 forks source link

Dev version feedback on split of voicing responses #228

Closed zepumph closed 3 years ago

zepumph commented 3 years ago

Now that https://github.com/phetsims/friction/issues/211 is complete, where object/context/hint responses were split into their voicing categories, we are ready for some more fine tuned feedback on the design and on timing. Over to @Matthew-Moore240, hopefully we can get some good progress on this before our meeting on Friday.

https://phet-dev.colorado.edu/html/friction/1.6.0-dev.13/phet/friction_all_phet.html?voicingInitiallyEnabled

Have fun!

zepumph commented 3 years ago

Latest and greatest: https://phet-dev.colorado.edu/html/friction/1.6.0-dev.14/phet/friction_all_phet.html?voicingInitiallyEnabled

Matthew-Moore240 commented 3 years ago

With all checkmarks on

zepumph commented 3 years ago

@terracoda put thoughts in https://github.com/phetsims/friction/issues/231#issuecomment-920894882

terracoda commented 3 years ago

@Matthew-Moore240 and @terracoda reviewed and we think the interruption and pause is related to #234. The response gets interrupted by a cooling response, but the cooling response is blank at the moment.

Let's review this after #234 is fixed.

zepumph commented 3 years ago

https://github.com/phetsims/friction/issues/234 is fixed. Back to you here if it still makes sense. I added a dev version for testing. https://phet-dev.colorado.edu/html/friction/1.6.0-dev.15/phet/friction_en_phet.html?voicingInitiallyEnabled

terracoda commented 3 years ago

The responses seem like they are all in the correct categories. Closing.