Closed zepumph closed 3 years ago
From that comment:
I never hear the move-down hint, even when rubbing back and forth several times and I do not bring the books together.
I have potentially fixed this with two items.
Please review, and let me know if you want to talk through this. This is only on master right now, not on dev.15
This sounds pretty good.
@Matthew-Moore240 and @terracoda discussed, and we feel it would be better if there was some movement (some interaction) before you get move down to rub harder.
That said, if movement and space simultaneously are hard to detect we can live with it as is.
The main idea of the response is that it indicates unproductive rubbing. Having it fire with just air space seems a little extra directive, but not terrible.
@terracoda @zepumph and @Matthew-Moore240 Reviewed this together and decided to leave it as is. Closing.
https://github.com/phetsims/friction/commit/30ad85bdcd7a1f3ddbf4c2e205dfa8bb3de99281 doesn't seem to cut it to me. I was reviewing this code over in https://github.com/phetsims/friction/issues/242#issuecomment-933686906 and think it needs to be reworked. It will be done over in https://github.com/phetsims/friction/issues/253 where Utterance timing variables will be used instead of in house counting.
From https://github.com/phetsims/friction/issues/231#issuecomment-920894882, we need to update FrictionDragListener so that we don't wait until endDrag to alert. Let's prototype with trying to do it every X drags. Otherwise we may just have to use the Utterance timing variables for this, but I don't see it as a good fit.